fix: Server only session issues with parent synchronize and networkobjecteditor #3139
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NoelStephensUnity
deleted the
fix/server-only-revent-v2-issues-discovered
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves two issues discovered while fiddling around with a server hosted (i.e. non-host) session specific project.
NetworkBehaviorEditor: Would throw exceptions if you tried to view the observers of a spawnedNetworkObject.ParentSyncMessage: Was exiting when a server would receive a message from a client. We now allow clients to parent locally if they have the "Allow Owner to Parent" setting enabled.Changelog
NetworkBehaviorEditorwould throw exceptions if you tried to view the observers of a spawnedNetworkObject.ParentSyncMessagewas exiting early during serialization when a server would receive a message from a client. We now allow clients to parent locally if they have the "Allow Owner to Parent" setting enabled and so this is a valid scenario.Testing and Documentation